Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DTFS2-7781): add effective from date e2e tests #4189

Merged
merged 6 commits into from
Feb 4, 2025
Merged

feat(DTFS2-7781): add effective from date e2e tests #4189

merged 6 commits into from
Feb 4, 2025

Conversation

MarRobSoftwire
Copy link
Contributor

@MarRobSoftwire MarRobSoftwire commented Jan 29, 2025 •
edited
Loading

Introduction ✏️

We need e2e tests for the new effective from page

Resolution ✔️

  • Update journey e2e tests to include effective from
  • Add e2e test for effective from page

Misc ➕

  • I noticed a discrepancy between the TfmFacilities amendment type and the schema - I've updated all occurances of effectiveFrom with effectiveDate

@MarRobSoftwire MarRobSoftwire changed the title Feat/dtfs2 7781/add effective from date e2e tests feat(DTFS2-7781)add effective from date e2e tests Jan 29, 2025
@MarRobSoftwire MarRobSoftwire changed the base branch from main to feat/DTFS2-7780/post-effective-from-date January 29, 2025 16:52
@MarRobSoftwire MarRobSoftwire force-pushed the feat/DTFS2-7781/add-effective-from-date-e2e-tests branch from 20c495c to 8ab91a8 Compare January 29, 2025 16:54
@MarRobSoftwire MarRobSoftwire self-assigned this Jan 29, 2025
@MarRobSoftwire MarRobSoftwire added the Test Unit, API, E2E and Test coverage documentation label Jan 29, 2025
@MarRobSoftwire MarRobSoftwire changed the title feat(DTFS2-7781)add effective from date e2e tests feat(DTFS2-7781): add effective from date e2e tests Jan 30, 2025
Base automatically changed from feat/DTFS2-7780/post-effective-from-date to main January 30, 2025 16:47
@MarRobSoftwire MarRobSoftwire force-pushed the feat/DTFS2-7781/add-effective-from-date-e2e-tests branch from 8ab91a8 to b582db7 Compare January 30, 2025 16:49
BethThomas141
BethThomas141 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@BethThomas141 BethThomas141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MarRobSoftwire MarRobSoftwire marked this pull request as ready for review February 4, 2025 11:49
@MarRobSoftwire MarRobSoftwire merged commit 15c0470 into main Feb 4, 2025
238 of 239 checks passed
@MarRobSoftwire MarRobSoftwire deleted the feat/DTFS2-7781/add-effective-from-date-e2e-tests branch February 4, 2025 16:09
@abhi-markan abhi-markan mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethThomas141 BethThomas141 BethThomas141 approved these changes

@rkontogianni rkontogianni rkontogianni approved these changes

Assignees

@MarRobSoftwire MarRobSoftwire

Labels
Test Unit, API, E2E and Test coverage documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarRobSoftwire @BethThomas141 @rkontogianni